From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22517 invoked by alias); 4 Dec 2013 23:33:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22505 invoked by uid 89); 4 Dec 2013 23:33:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2013 23:33:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB4NX7Ys003499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 4 Dec 2013 18:33:07 -0500 Received: from psique (ovpn-113-192.phx2.redhat.com [10.3.113.192]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rB4NX42I007455 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 4 Dec 2013 18:33:06 -0500 From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Patches , Marcus Shawcroft Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: <1385336092-19621-1-git-send-email-sergiodj@redhat.com> <87wqjt222h.fsf@fleche.redhat.com> X-URL: http://www.redhat.com Date: Wed, 04 Dec 2013 23:33:00 -0000 In-Reply-To: <87wqjt222h.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 27 Nov 2013 10:21:10 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00161.txt.bz2 On Wednesday, November 27 2013, Tom Tromey wrote: > FWIW in this specific case I think this testing approach is ok. > The patch pretty clearly just touches the stap probe code. > Could you say, though, exactly which tests you ran? Thanks. For this case, I ran manually the tests from gdb.base/stap-probe.exp, checking the results and making sure everything is working OK. Since the AArch64 asm permits more than one numeric literal prefix to be used, I hacked the generated assembly in order to test this too. Soon I will post a patch that extends the current generic parser to accept multiple prefixes/suffixes, and then I will repost this AArch64 support patch on top of it. -- Sergio