Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: dje@google.com
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	Pedro Alves <palves@redhat.com>,
	       gdb-patches@sourceware.org, ratmice@gmail.com
Subject: Re: [RFA] massively speed up "info var foo" on large programs
Date: Tue, 31 Jul 2012 07:19:00 -0000	[thread overview]
Message-ID: <m37gtko0tm.fsf@redhat.com> (raw)
In-Reply-To: <20502.50281.392575.922986@ruffy2.mtv.corp.google.com>	(dje@google.com's message of "Mon, 30 Jul 2012 10:29:13 -0700")

On Monday, July 30 2012, dje@google.com wrote:

> I'm not sure how much effort to put into handling all the variations here.
> I'm happy with this, but I'm also happy with anything that fixes your regression.
>
> This is regression tested on amd64-linux.
> Can you try this on m68k-linux?  Thanks.

I was seeing the same failures as Andreas on PPC64 and s390x (in fact I
was working on a patch for it now, but you were faster), when I
regtested 7.4 against 7.5 on RHEL 6.3.

I have just tested your patch on ppc64 and it works OK; I don't have a
s390x machine right now but I'll check tomorrow when I wake up.

> 2012-07-30  Doug Evans  <dje@google.com>
>
> 	* gdb.base/info-fun.exp: Fix failures on m68k-linux.

Given that these failures also happen on ppc64 and s390x due to the same
reason, I believe this and the other sentences specifically mentioning
m68k-linux can be more generic.

I also vote for committing this in the 7.5 branch.

Thanks,

-- 
Sergio


  reply	other threads:[~2012-07-31  7:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 17:59 Doug Evans
2012-05-24 21:28 ` Doug Evans
2012-05-25  4:29   ` Matt Rice
2012-05-25  8:21   ` Doug Evans
2012-05-25  8:51     ` Pedro Alves
2012-05-28  4:49       ` Doug Evans
2012-05-31 18:53         ` Doug Evans
2012-06-01 19:38         ` Pedro Alves
2012-06-04  4:06           ` Doug Evans
2012-06-04 15:03             ` Pedro Alves
2012-06-19  0:58               ` Doug Evans
2012-07-19  9:18                 ` Andreas Schwab
2012-07-30 17:29                   ` dje
2012-07-31  7:19                     ` Sergio Durigan Junior [this message]
2012-08-01  5:18                       ` Sergio Durigan Junior
2012-08-01 19:30                         ` dje
2012-05-25 10:04     ` Matt Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37gtko0tm.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=ratmice@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox