From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28419 invoked by alias); 31 Jul 2012 07:19:20 -0000 Received: (qmail 28406 invoked by uid 22791); 31 Jul 2012 07:19:18 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Jul 2012 07:18:56 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6V7Io1P009937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Jul 2012 03:18:50 -0400 Received: from psique (ovpn-113-52.phx2.redhat.com [10.3.113.52]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6V7IkGD030885; Tue, 31 Jul 2012 03:18:47 -0400 From: Sergio Durigan Junior To: dje@google.com Cc: Andreas Schwab , Pedro Alves , gdb-patches@sourceware.org, ratmice@gmail.com Subject: Re: [RFA] massively speed up "info var foo" on large programs References: <20120524175852.D38381E139C@ruffy2.mtv.corp.google.com> <4FBF47DD.4030100@redhat.com> <4FC91A33.5040900@redhat.com> <4FCCCE27.2060804@redhat.com> <20502.50281.392575.922986@ruffy2.mtv.corp.google.com> X-URL: http://www.redhat.com Date: Tue, 31 Jul 2012 07:19:00 -0000 In-Reply-To: <20502.50281.392575.922986@ruffy2.mtv.corp.google.com> (dje@google.com's message of "Mon, 30 Jul 2012 10:29:13 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00780.txt.bz2 On Monday, July 30 2012, dje@google.com wrote: > I'm not sure how much effort to put into handling all the variations here. > I'm happy with this, but I'm also happy with anything that fixes your regression. > > This is regression tested on amd64-linux. > Can you try this on m68k-linux? Thanks. I was seeing the same failures as Andreas on PPC64 and s390x (in fact I was working on a patch for it now, but you were faster), when I regtested 7.4 against 7.5 on RHEL 6.3. I have just tested your patch on ppc64 and it works OK; I don't have a s390x machine right now but I'll check tomorrow when I wake up. > 2012-07-30 Doug Evans > > * gdb.base/info-fun.exp: Fix failures on m68k-linux. Given that these failures also happen on ppc64 and s390x due to the same reason, I believe this and the other sentences specifically mentioning m68k-linux can be more generic. I also vote for committing this in the 7.5 branch. Thanks, -- Sergio