From: Matt Rice <ratmice@gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] massively speed up "info var foo" on large programs
Date: Fri, 25 May 2012 10:04:00 -0000 [thread overview]
Message-ID: <CACTLOFpSJMNwrRT4go9ifoZ+V9KQ+VckFCJedgbOy1aXQxBS1g@mail.gmail.com> (raw)
In-Reply-To: <CADPb22ROtFjAWBrCRVu-8QqHKBjqmR+FSRAonHQMAFPU=m02pA@mail.gmail.com>
On Fri, May 25, 2012 at 1:21 AM, Doug Evans <dje@google.com> wrote:
> It scans separate debug files.
>
>+ if (objfile->separate_debug_objfile_backlink)
>+ main_objfile = objfile->separate_debug_objfile_backlink;
>+ else
>+ main_objfile = objfile;
I'm wondering if this is OK/necessary from objfiles.h:
Note that separate debug object are in the main chain and therefore
will be visited by ALL_OBJFILES & co iterators.
> ALL_MSYMBOLS (objfile, msymbol)
> {
> QUIT;
>
>+ if (msymbol->created_by_gdb)
>+ continue;
>+
so shouldn't ALL_MSYMBOLS (which calls ALL_OBJFILES) cover it,
and the separate debuginfo code above potentially cause symbols in
separate debuginfo objfiles to be listed twice?
prev parent reply other threads:[~2012-05-25 10:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 17:59 Doug Evans
2012-05-24 21:28 ` Doug Evans
2012-05-25 4:29 ` Matt Rice
2012-05-25 8:21 ` Doug Evans
2012-05-25 8:51 ` Pedro Alves
2012-05-28 4:49 ` Doug Evans
2012-05-31 18:53 ` Doug Evans
2012-06-01 19:38 ` Pedro Alves
2012-06-04 4:06 ` Doug Evans
2012-06-04 15:03 ` Pedro Alves
2012-06-19 0:58 ` Doug Evans
2012-07-19 9:18 ` Andreas Schwab
2012-07-30 17:29 ` dje
2012-07-31 7:19 ` Sergio Durigan Junior
2012-08-01 5:18 ` Sergio Durigan Junior
2012-08-01 19:30 ` dje
2012-05-25 10:04 ` Matt Rice [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACTLOFpSJMNwrRT4go9ifoZ+V9KQ+VckFCJedgbOy1aXQxBS1g@mail.gmail.com \
--to=ratmice@gmail.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox