From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91525-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9376 invoked by alias); 25 May 2012 10:04:51 -0000
Received: (qmail 9368 invoked by uid 22791); 25 May 2012 10:04:50 -0000
X-SWARE-Spam-Status: No, hits=-5.2 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ
X-Spam-Check-By: sourceware.org
Received: from mail-lb0-f169.google.com (HELO mail-lb0-f169.google.com) (209.85.217.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 May 2012 10:04:36 +0000
Received: by lbjn8 with SMTP id n8so623964lbj.0        for <gdb-patches@sourceware.org>; Fri, 25 May 2012 03:04:35 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.152.131.9 with SMTP id oi9mr2844215lab.39.1337940275393; Fri, 25 May 2012 03:04:35 -0700 (PDT)
Received: by 10.112.44.70 with HTTP; Fri, 25 May 2012 03:04:35 -0700 (PDT)
In-Reply-To: <CADPb22ROtFjAWBrCRVu-8QqHKBjqmR+FSRAonHQMAFPU=m02pA@mail.gmail.com>
References: <20120524175852.D38381E139C@ruffy2.mtv.corp.google.com>	<CADPb22T1K5sHhddJtCg0iURbyL7oQngFBVJ23gAsfz58qWQ0Ww@mail.gmail.com>	<CADPb22ROtFjAWBrCRVu-8QqHKBjqmR+FSRAonHQMAFPU=m02pA@mail.gmail.com>
Date: Fri, 25 May 2012 10:04:00 -0000
Message-ID: <CACTLOFpSJMNwrRT4go9ifoZ+V9KQ+VckFCJedgbOy1aXQxBS1g@mail.gmail.com>
Subject: Re: [RFA] massively speed up "info var foo" on large programs
From: Matt Rice <ratmice@gmail.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00967.txt.bz2

On Fri, May 25, 2012 at 1:21 AM, Doug Evans <dje@google.com> wrote:

> It scans separate debug files.
>
>+  if (objfile->separate_debug_objfile_backlink)
>+    main_objfile = objfile->separate_debug_objfile_backlink;
>+  else
>+    main_objfile = objfile;

I'm wondering if this is OK/necessary from objfiles.h:

Note that separate debug object are in the main chain and therefore
will be visited by ALL_OBJFILES & co iterators.

>       ALL_MSYMBOLS (objfile, msymbol)
>       {
>         QUIT;
>
>+	if (msymbol->created_by_gdb)
>+	  continue;
>+

so shouldn't ALL_MSYMBOLS (which calls ALL_OBJFILES) cover it,
and the separate debuginfo code above potentially cause symbols in
separate debuginfo objfiles to be listed twice?