Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] PR 13369/13374
Date: Mon, 21 Nov 2011 20:09:00 -0000	[thread overview]
Message-ID: <m362id9r1r.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3ipmdem7n.fsf@redhat.com> (Phil Muldoon's message of "Mon, 21	Nov 2011 11:42:04 +0000")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> @@ -157,15 +157,9 @@ inferior_to_inferior_object (struct inferior *inferior)
Phil>    inf_obj = inferior_data (inferior, infpy_inf_data_key);
Phil>    if (!inf_obj)
Phil>      {
Phil> -      struct cleanup *cleanup;
Phil> -      cleanup = ensure_python_env (python_gdbarch, python_language);
Phil> -
Phil>        inf_obj = PyObject_New (inferior_object, &inferior_object_type);
Phil>        if (!inf_obj)
Phil> -	{
Phil> -	  do_cleanups (cleanup);
Phil>  	  return NULL;
Phil> -	}

This doesn't handle the call chain

delete_thread_object -> find_inferior_object -> inferior_to_inferior_object

Tom


  parent reply	other threads:[~2011-11-21 20:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 11:42 Phil Muldoon
2011-11-21 11:50 ` Paul_Koning
2011-11-21 19:59   ` Tom Tromey
2011-11-21 20:09 ` Tom Tromey [this message]
2011-11-22 12:16   ` Phil Muldoon
2011-11-22 18:01     ` Tom Tromey
2011-11-28 16:02       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m362id9r1r.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox