From: <Paul_Koning@Dell.com>
To: <pmuldoon@redhat.com>, <gdb-patches@sourceware.org>
Subject: RE: [python] [patch] PR 13369/13374
Date: Mon, 21 Nov 2011 11:50:00 -0000 [thread overview]
Message-ID: <09787EF419216C41A903FD14EE5506DD030EBD9671@AUSX7MCPC103.AMER.DELL.COM> (raw)
In-Reply-To: <m3ipmdem7n.fsf@redhat.com>
>...
>diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
>index f76b1c7..b671cef 100644
>--- a/gdb/python/py-type.c
>+++ b/gdb/python/py-type.c
>...
>@@ -779,8 +787,13 @@ typy_legacy_template_argument (struct type *type, const struct block >*block,
> return NULL;
> }
>
>- /* Note -- this is not thread-safe. */
>- info = cp_demangled_name_to_comp (TYPE_NAME (type), &err);
>+ TRY_CATCH (except, RETURN_MASK_ALL)
>+ {
>+ /* Note -- this is not thread-safe. */
Does the comment "not thread safe" indicate that this is a spot where the GIL should be acquired and isn't currently? Or doesn't the GIL help for that?
paul
next prev parent reply other threads:[~2011-11-21 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 11:42 Phil Muldoon
2011-11-21 11:50 ` Paul_Koning [this message]
2011-11-21 19:59 ` Tom Tromey
2011-11-21 20:09 ` Tom Tromey
2011-11-22 12:16 ` Phil Muldoon
2011-11-22 18:01 ` Tom Tromey
2011-11-28 16:02 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09787EF419216C41A903FD14EE5506DD030EBD9671@AUSX7MCPC103.AMER.DELL.COM \
--to=paul_koning@dell.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox