From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15292 invoked by alias); 21 Nov 2011 11:50:23 -0000 Received: (qmail 15283 invoked by uid 22791); 21 Nov 2011 11:50:22 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ausxipps301.us.dell.com (HELO ausxipps301.us.dell.com) (143.166.148.223) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Nov 2011 11:50:08 +0000 X-Loopcount0: from 10.175.216.251 From: To: , Date: Mon, 21 Nov 2011 11:50:00 -0000 Subject: RE: [python] [patch] PR 13369/13374 Message-ID: <09787EF419216C41A903FD14EE5506DD030EBD9671@AUSX7MCPC103.AMER.DELL.COM> References: In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00541.txt.bz2 >... >diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c >index f76b1c7..b671cef 100644 >--- a/gdb/python/py-type.c >+++ b/gdb/python/py-type.c >... >@@ -779,8 +787,13 @@ typy_legacy_template_argument (struct type *type, con= st struct block >*block, > return NULL; > } >=20 >- /* Note -- this is not thread-safe. */ >- info =3D cp_demangled_name_to_comp (TYPE_NAME (type), &err); >+ TRY_CATCH (except, RETURN_MASK_ALL) >+ { >+ /* Note -- this is not thread-safe. */ Does the comment "not thread safe" indicate that this is a spot where the G= IL should be acquired and isn't currently? Or doesn't the GIL help for tha= t? paul