From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21661 invoked by alias); 21 Nov 2011 20:09:05 -0000 Received: (qmail 21649 invoked by uid 22791); 21 Nov 2011 20:09:03 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Nov 2011 20:08:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pALK8osZ023914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Nov 2011 15:08:50 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pALK8nnP015884; Mon, 21 Nov 2011 15:08:50 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pALK8muC021807; Mon, 21 Nov 2011 15:08:49 -0500 From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [python] [patch] PR 13369/13374 References: Date: Mon, 21 Nov 2011 20:09:00 -0000 In-Reply-To: (Phil Muldoon's message of "Mon, 21 Nov 2011 11:42:04 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00547.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> @@ -157,15 +157,9 @@ inferior_to_inferior_object (struct inferior *inferior) Phil> inf_obj = inferior_data (inferior, infpy_inf_data_key); Phil> if (!inf_obj) Phil> { Phil> - struct cleanup *cleanup; Phil> - cleanup = ensure_python_env (python_gdbarch, python_language); Phil> - Phil> inf_obj = PyObject_New (inferior_object, &inferior_object_type); Phil> if (!inf_obj) Phil> - { Phil> - do_cleanups (cleanup); Phil> return NULL; Phil> - } This doesn't handle the call chain delete_thread_object -> find_inferior_object -> inferior_to_inferior_object Tom