From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Pedro Alves <palves@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Improve and fix catch-syscall.exp
Date: Wed, 18 Dec 2013 22:26:00 -0000 [thread overview]
Message-ID: <m361qlssnl.fsf@redhat.com> (raw)
In-Reply-To: <CAP9bCMREgYYoBMh6EaSDBrg8xsVHCu0hkF7hFK6_oA4L+s2h9A@mail.gmail.com> (Doug Evans's message of "Wed, 18 Dec 2013 13:10:26 -0800")
On Wednesday, December 18 2013, Doug Evans wrote:
> Two nits. Ok with the changes below.
>
>> @@ -428,47 +391,35 @@ proc do_syscall_tests_without_xml {} {
>>
>> # This procedure fills the vector "all_syscalls_numbers" with the proper
>> # numbers for the used syscalls according to the architecture.
>> +#
>> +# These numbers were taken from the respective <asm/unistd.h> files
>> +# from each architecture.
>
> This comment can go (no longer needed).
>
>>
>> -gdb_exit
>> -set do_xml_test ![gdb_skip_xml_test]
>> -gdb_start
>> -gdb_reinitialize_dir $srcdir/$subdir
>> -gdb_load ${binfile}
>> +# Filling all the syscalls numbers before starting anything.
>
> s/Filling/Fill/
Fixed all nits. Thank you and Pedro for the review. Checked-in:
<https://sourceware.org/ml/gdb-cvs/2013-12/msg00097.html>
--
Sergio
next prev parent reply other threads:[~2013-12-18 22:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 23:06 Sergio Durigan Junior
2013-12-15 18:31 ` Doug Evans
2013-12-15 18:44 ` Doug Evans
2013-12-16 4:24 ` Sergio Durigan Junior
2013-12-16 4:20 ` Sergio Durigan Junior
2013-12-16 23:09 ` Sergio Durigan Junior
2013-12-17 10:24 ` Pedro Alves
2013-12-17 17:35 ` Sergio Durigan Junior
2013-12-18 21:10 ` Doug Evans
2013-12-18 22:26 ` Sergio Durigan Junior [this message]
2013-12-16 17:50 ` Pedro Alves
2013-12-16 17:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m361qlssnl.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox