From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108524-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1196 invoked by alias); 18 Dec 2013 22:26:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 1182 invoked by uid 89); 18 Dec 2013 22:26:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2013 22:25:56 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBIMPsJI015365	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 18 Dec 2013 17:25:54 -0500
Received: from psique (ovpn-113-148.phx2.redhat.com [10.3.113.148])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBIMPpMd015991	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 18 Dec 2013 17:25:53 -0500
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: Pedro Alves <palves@redhat.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Improve and fix catch-syscall.exp
References: <m37gb85p2o.fsf@redhat.com> <m3a9g27yr8.fsf@sspiff.org>	<m38uvkxuiy.fsf@redhat.com> <52B02635.2090405@redhat.com>	<m338lrwfbm.fsf@redhat.com>	<CAP9bCMREgYYoBMh6EaSDBrg8xsVHCu0hkF7hFK6_oA4L+s2h9A@mail.gmail.com>
X-URL: http://www.redhat.com
Date: Wed, 18 Dec 2013 22:26:00 -0000
In-Reply-To: <CAP9bCMREgYYoBMh6EaSDBrg8xsVHCu0hkF7hFK6_oA4L+s2h9A@mail.gmail.com>	(Doug Evans's message of "Wed, 18 Dec 2013 13:10:26 -0800")
Message-ID: <m361qlssnl.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00728.txt.bz2

On Wednesday, December 18 2013, Doug Evans wrote:

> Two nits.  Ok with the changes below.
>
>> @@ -428,47 +391,35 @@ proc do_syscall_tests_without_xml {} {
>>
>>  # This procedure fills the vector "all_syscalls_numbers" with the proper
>>  # numbers for the used syscalls according to the architecture.
>> +#
>> +# These numbers were taken from the respective <asm/unistd.h> files
>> +# from each architecture.
>
> This comment can go (no longer needed).
>
>>
>> -gdb_exit
>> -set do_xml_test ![gdb_skip_xml_test]
>> -gdb_start
>> -gdb_reinitialize_dir $srcdir/$subdir
>> -gdb_load ${binfile}
>> +# Filling all the syscalls numbers before starting anything.
>
> s/Filling/Fill/

Fixed all nits.  Thank you and Pedro for the review.  Checked-in:

<https://sourceware.org/ml/gdb-cvs/2013-12/msg00097.html>

-- 
Sergio