From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Doug Evans <xdje42@gmail.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Improve and fix catch-syscall.exp
Date: Tue, 17 Dec 2013 10:24:00 -0000 [thread overview]
Message-ID: <52B02635.2090405@redhat.com> (raw)
In-Reply-To: <m38uvkxuiy.fsf@redhat.com>
On 12/16/2013 11:09 PM, Sergio Durigan Junior wrote:
> + set close_syscall [get_integer_valueof "close_syscall" 0]
> + set chroot_syscall [get_integer_valueof "chroot_syscall" 0]
> + set all_syscalls_numbers [list $close_syscall $chroot_syscall]
> + set last_syscall_number [get_integer_valueof "exit_group_syscall" 0]
Minor nit:
As we saw in the other patch, using 0 for invalid syscall
number isn't a good idea. It shouldn't really matter much in
practice but for code clarity I suggest defaulting to -1 instead.
--
Pedro Alves
next prev parent reply other threads:[~2013-12-17 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 23:06 Sergio Durigan Junior
2013-12-15 18:31 ` Doug Evans
2013-12-15 18:44 ` Doug Evans
2013-12-16 4:24 ` Sergio Durigan Junior
2013-12-16 4:20 ` Sergio Durigan Junior
2013-12-16 23:09 ` Sergio Durigan Junior
2013-12-17 10:24 ` Pedro Alves [this message]
2013-12-17 17:35 ` Sergio Durigan Junior
2013-12-18 21:10 ` Doug Evans
2013-12-18 22:26 ` Sergio Durigan Junior
2013-12-16 17:50 ` Pedro Alves
2013-12-16 17:59 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B02635.2090405@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox