From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12495 invoked by alias); 17 Dec 2013 10:24:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12486 invoked by uid 89); 17 Dec 2013 10:24:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2013 10:24:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHAO6HB031355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Dec 2013 05:24:07 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBHAO4QD004489; Tue, 17 Dec 2013 05:24:05 -0500 Message-ID: <52B02635.2090405@redhat.com> Date: Tue, 17 Dec 2013 10:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: Doug Evans , GDB Patches Subject: Re: [PATCH] Improve and fix catch-syscall.exp References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00620.txt.bz2 On 12/16/2013 11:09 PM, Sergio Durigan Junior wrote: > + set close_syscall [get_integer_valueof "close_syscall" 0] > + set chroot_syscall [get_integer_valueof "chroot_syscall" 0] > + set all_syscalls_numbers [list $close_syscall $chroot_syscall] > + set last_syscall_number [get_integer_valueof "exit_group_syscall" 0] Minor nit: As we saw in the other patch, using 0 for invalid syscall number isn't a good idea. It shouldn't really matter much in practice but for code clarity I suggest defaulting to -1 instead. -- Pedro Alves