Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] PR 11417
Date: Tue, 30 Mar 2010 18:05:00 -0000	[thread overview]
Message-ID: <m34ojxwuq0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BB20EC0.10500@redhat.com> (Phil Muldoon's message of "Tue, 30 	Mar 2010 15:46:24 +0100")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> -  if (address == 0)
Phil> -    {
Phil> -      PyErr_SetString (PyExc_MemoryError,
Phil> -		       "Cannot create a lazy string from a GDB-side string.");
Phil> -      return NULL;
Phil> -    }

I agree that we should change lazy_string to be like string here.
However, I think we should only allow a NULL lazy_string with length==0.
Other situations don't really make sense.

This also needs a test case.

thanks,
Tom


  reply	other threads:[~2010-03-30 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30 14:46 Phil Muldoon
2010-03-30 18:05 ` Tom Tromey [this message]
2010-03-31 10:07   ` Phil Muldoon
2010-04-07 20:58     ` Tom Tromey
2010-04-08 12:38       ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34ojxwuq0.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox