From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] PR 11417
Date: Thu, 08 Apr 2010 12:38:00 -0000 [thread overview]
Message-ID: <4BBDCE42.60002@redhat.com> (raw)
In-Reply-To: <m3sk77t1y0.fsf@fleche.redhat.com>
On 04/07/2010 09:58 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> + if (self_string->address == 0)
> Phil> + {
> Phil> + PyErr_SetString (PyExc_MemoryError,
> Phil> + "Cannot create a value from NULL");
>
> As Joel pointed out in another thread, this should have _().
>
> This is ok with that change. Thanks.
So committed with that change.
Cheers,
Phil
prev parent reply other threads:[~2010-04-08 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 14:46 Phil Muldoon
2010-03-30 18:05 ` Tom Tromey
2010-03-31 10:07 ` Phil Muldoon
2010-04-07 20:58 ` Tom Tromey
2010-04-08 12:38 ` Phil Muldoon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBDCE42.60002@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox