From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71855-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29788 invoked by alias); 8 Apr 2010 12:38:34 -0000
Received: (qmail 29780 invoked by uid 22791); 8 Apr 2010 12:38:33 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Apr 2010 12:38:29 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o38CcRWo022478 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Thu, 8 Apr 2010 08:38:28 -0400
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o38CcQ0T016748; 	Thu, 8 Apr 2010 08:38:27 -0400
Message-ID: <4BBDCE42.60002@redhat.com>
Date: Thu, 08 Apr 2010 12:38:00 -0000
From: Phil Muldoon <pmuldoon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] PR 11417
References: <4BB20EC0.10500@redhat.com> <m34ojxwuq0.fsf@fleche.redhat.com>	<4BB31ECC.10104@redhat.com> <m3sk77t1y0.fsf@fleche.redhat.com>
In-Reply-To: <m3sk77t1y0.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00174.txt.bz2

On 04/07/2010 09:58 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> 
> Phil> +  if (self_string->address == 0)
> Phil> +    {
> Phil> +      PyErr_SetString (PyExc_MemoryError,
> Phil> +		       "Cannot create a value from NULL");
> 
> As Joel pointed out in another thread, this should have _().
> 
> This is ok with that change.  Thanks.

So committed with that change.

Cheers,

Phil