From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71630-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7342 invoked by alias); 30 Mar 2010 18:05:54 -0000
Received: (qmail 7330 invoked by uid 22791); 30 Mar 2010 18:05:53 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 18:05:47 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UI5kUg021889 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Tue, 30 Mar 2010 14:05:46 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UI5imZ026060; 	Tue, 30 Mar 2010 14:05:45 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UI5hiV020334; 	Tue, 30 Mar 2010 14:05:43 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 1B90F508258; Tue, 30 Mar 2010 12:05:43 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] PR 11417
References: <4BB20EC0.10500@redhat.com>
Reply-To: tromey@redhat.com
Date: Tue, 30 Mar 2010 18:05:00 -0000
In-Reply-To: <4BB20EC0.10500@redhat.com> (Phil Muldoon's message of "Tue, 30 	Mar 2010 15:46:24 +0100")
Message-ID: <m34ojxwuq0.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg01075.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> -  if (address == 0)
Phil> -    {
Phil> -      PyErr_SetString (PyExc_MemoryError,
Phil> -		       "Cannot create a lazy string from a GDB-side string.");
Phil> -      return NULL;
Phil> -    }

I agree that we should change lazy_string to be like string here.
However, I think we should only allow a NULL lazy_string with length==0.
Other situations don't really make sense.

This also needs a test case.

thanks,
Tom