From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] do not use python<version> subdir when including Python .h file
Date: Fri, 28 Jan 2011 11:24:00 -0000 [thread overview]
Message-ID: <m34o8ti8a5.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1295739863-1006-2-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sat, 22 Jan 2011 18:44:22 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> One last change is the fact that we are now including Python.h
Joel> and all other Python include headers using angle brackets rather
Joel> than double-quotes. This fixes a problem on case-insensitive
Joel> systems where #include "Python.h" causes our gdb/python/python.h
Joel> header to be included instead of Python's <Python.h> header.
How does this work when srcdir != builddir? In that case isn't our
python.h found only via a -I option? Thus causing a clash?
Anyway, this patch looks fine to me. If the above is a non-issue, go
for it. If it is an issue, I didn't mind your earlier patch to rename
it to gdb-python.h.
Tom
next prev parent reply other threads:[~2011-01-28 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 23:45 Allow building GDB with Python support on Windows/MinGW Joel Brobecker
2011-01-22 23:45 ` [RFA 2/2] allow building GDB with Python support on MinGW Joel Brobecker
2011-01-28 11:32 ` Tom Tromey
2011-01-31 4:50 ` Joel Brobecker
2011-01-23 0:14 ` [RFA 1/2] do not use python<version> subdir when including Python .h file Joel Brobecker
2011-01-28 11:24 ` Tom Tromey [this message]
2011-01-28 14:37 ` Joel Brobecker
2011-01-28 14:54 ` Tom Tromey
2011-01-31 4:44 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o8ti8a5.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox