Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/2] do not use python<version> subdir when including Python .h file
Date: Fri, 28 Jan 2011 14:37:00 -0000	[thread overview]
Message-ID: <20110128140947.GB2467@adacore.com> (raw)
In-Reply-To: <m34o8ti8a5.fsf@fleche.redhat.com>

Thanks for looking at the patches, Tom.

> Joel> One last change is the fact that we are now including Python.h
> Joel> and all other Python include headers using angle brackets rather
> Joel> than double-quotes.  This fixes a problem on case-insensitive
> Joel> systems where #include "Python.h" causes our gdb/python/python.h
> Joel> header to be included instead of Python's <Python.h> header.
> 
> How does this work when srcdir != builddir?  In that case isn't our
> python.h found only via a -I option?  Thus causing a clash?

I discovered while working on this that there is actually no -I option
for the gdb/python directory (I thought that we did and I was looking
at that in an attempt to eliminate it).  Files from the gdb/ directory
include our python headers using #include "python/python-internal.h",
while files in the gdb/python/ directory include them more directly
using #include "python-internal.h". 

I do my builds out of tree almost exclusively, I can't remember when
the last time was that I built in-tree. I know that it works in this
case, but I should probably double-check in-tree as well.  I will do
that as soon as I come back from my vacation :-).

-- 
Joel


  reply	other threads:[~2011-01-28 14:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-22 23:45 Allow building GDB with Python support on Windows/MinGW Joel Brobecker
2011-01-22 23:45 ` [RFA 2/2] allow building GDB with Python support on MinGW Joel Brobecker
2011-01-28 11:32   ` Tom Tromey
2011-01-31  4:50     ` Joel Brobecker
2011-01-23  0:14 ` [RFA 1/2] do not use python<version> subdir when including Python .h file Joel Brobecker
2011-01-28 11:24   ` Tom Tromey
2011-01-28 14:37     ` Joel Brobecker [this message]
2011-01-28 14:54       ` Tom Tromey
2011-01-31  4:44   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110128140947.GB2467@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox