From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22788 invoked by alias); 28 Jan 2011 14:10:08 -0000 Received: (qmail 22777 invoked by uid 22791); 28 Jan 2011 14:10:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Jan 2011 14:10:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DB7FB2BACD4; Fri, 28 Jan 2011 09:09:59 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8x-Mg2cPXziD; Fri, 28 Jan 2011 09:09:59 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 832B72BAB72; Fri, 28 Jan 2011 09:09:57 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 19B721459BF; Fri, 28 Jan 2011 18:09:47 +0400 (RET) Date: Fri, 28 Jan 2011 14:37:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] do not use python subdir when including Python .h file Message-ID: <20110128140947.GB2467@adacore.com> References: <1295739863-1006-1-git-send-email-brobecker@adacore.com> <1295739863-1006-2-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00545.txt.bz2 Thanks for looking at the patches, Tom. > Joel> One last change is the fact that we are now including Python.h > Joel> and all other Python include headers using angle brackets rather > Joel> than double-quotes. This fixes a problem on case-insensitive > Joel> systems where #include "Python.h" causes our gdb/python/python.h > Joel> header to be included instead of Python's header. > > How does this work when srcdir != builddir? In that case isn't our > python.h found only via a -I option? Thus causing a clash? I discovered while working on this that there is actually no -I option for the gdb/python directory (I thought that we did and I was looking at that in an attempt to eliminate it). Files from the gdb/ directory include our python headers using #include "python/python-internal.h", while files in the gdb/python/ directory include them more directly using #include "python-internal.h". I do my builds out of tree almost exclusively, I can't remember when the last time was that I built in-tree. I know that it works in this case, but I should probably double-check in-tree as well. I will do that as soon as I come back from my vacation :-). -- Joel