From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26065 invoked by alias); 28 Jan 2011 11:21:17 -0000 Received: (qmail 26055 invoked by uid 22791); 28 Jan 2011 11:21:16 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Jan 2011 11:21:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0SBKpkT009789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jan 2011 06:20:51 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0SBKpQI021376; Fri, 28 Jan 2011 06:20:51 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p0SBKoVF025140; Fri, 28 Jan 2011 06:20:50 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 4CC4E3784E2; Fri, 28 Jan 2011 04:20:50 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] do not use python subdir when including Python .h file References: <1295739863-1006-1-git-send-email-brobecker@adacore.com> <1295739863-1006-2-git-send-email-brobecker@adacore.com> Date: Fri, 28 Jan 2011 11:24:00 -0000 In-Reply-To: <1295739863-1006-2-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sat, 22 Jan 2011 18:44:22 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00537.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> One last change is the fact that we are now including Python.h Joel> and all other Python include headers using angle brackets rather Joel> than double-quotes. This fixes a problem on case-insensitive Joel> systems where #include "Python.h" causes our gdb/python/python.h Joel> header to be included instead of Python's header. How does this work when srcdir != builddir? In that case isn't our python.h found only via a -I option? Thus causing a clash? Anyway, this patch looks fine to me. If the above is a non-issue, go for it. If it is an issue, I didn't mind your earlier patch to rename it to gdb-python.h. Tom