Re: [RFA/PATCH] Fix recognition of NT_PRXFREG notes

[Nick Clifton <nickc@cambridge.redhat.com>]

Hi Mark,

> After Alan's 2002-06-25 change some tests in GDB's testsuite have been
> failing on Linux.  Turns out the current code that reads NT_PRXFREG
> notes expects note->namesz to be 5, but with the trailing 0, the
> length of "LINUX" is 6.  Turns out the Linux kernel doesn't include
> the trailing 0 in the name size.  According to the Systemm V ABI the
> trailing 0 should be included, so Alan's change is correct and Linux
> is wrong here.  But since changing the Linux kernel isn't going to
> happen overnight, I propose the attached fix.
> 
> Ok to check this in?
 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* elf.c (elfcore_grok_note): Fix recognition of NT_PRXFREG notes.

Approved - but, please add a comment explaining this situation, so
that somebody is not tempted to change the code back.

Cheers
        Nick