From: Mark Kettenis <kettenis@chello.nl>
To: binutils@sources.redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: [RFA/PATCH] Fix recognition of NT_PRXFREG notes
Date: Thu, 04 Jul 2002 08:15:00 -0000 [thread overview]
Message-ID: <200207041503.g64F3Mj08511@elgar.kettenis.dyndns.org> (raw)
After Alan's 2002-06-25 change some tests in GDB's testsuite have been
failing on Linux. Turns out the current code that reads NT_PRXFREG
notes expects note->namesz to be 5, but with the trailing 0, the
length of "LINUX" is 6. Turns out the Linux kernel doesn't include
the trailing 0 in the name size. According to the Systemm V ABI the
trailing 0 should be included, so Alan's change is correct and Linux
is wrong here. But since changing the Linux kernel isn't going to
happen overnight, I propose the attached fix.
Ok to check this in?
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* elf.c (elfcore_grok_note): Fix recognition of NT_PRXFREG notes.
Index: elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.152
diff -u -p -r1.152 elf.c
--- elf.c 4 Jul 2002 13:26:30 -0000 1.152
+++ elf.c 4 Jul 2002 14:54:36 -0000
@@ -6718,8 +6718,7 @@ elfcore_grok_note (abfd, note)
#endif
case NT_PRXFPREG: /* Linux SSE extension */
- if (note->namesz == 5
- && ! strcmp (note->namedata, "LINUX"))
+ if (strncmp (note->namedata, "LINUX", 5) == 0)
return elfcore_grok_prxfpreg (abfd, note);
else
return true;
next reply other threads:[~2002-07-04 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-04 8:15 Mark Kettenis [this message]
2002-07-04 20:05 ` Alan Modra
2002-07-05 7:45 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207041503.g64F3Mj08511@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=binutils@sources.redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox