From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28202 invoked by alias); 5 Jul 2002 14:26:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28176 invoked from network); 5 Jul 2002 14:26:51 -0000 Received: from unknown (HELO dell-pe2450-3.cambridge.redhat.com) (195.224.55.225) by sources.redhat.com with SMTP; 5 Jul 2002 14:26:51 -0000 Received: from north-pole.nickc.cambridge.redhat.com (host213-121-126-16.in-addr.btopenworld.com [213.121.126.16]) by dell-pe2450-3.cambridge.redhat.com (Postfix) with ESMTP id D3BE88593C; Fri, 5 Jul 2002 15:26:50 +0100 (BST) Received: from north-pole.nickc.cambridge.redhat.com.nickc.cambridge.redhat.com (localhost [127.0.0.1]) by north-pole.nickc.cambridge.redhat.com (Postfix) with ESMTP id 745401C1DF; Fri, 5 Jul 2002 15:27:07 +0100 (BST) To: Mark Kettenis Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA/PATCH] Fix recognition of NT_PRXFREG notes References: <200207041503.g64F3Mj08511@elgar.kettenis.dyndns.org> From: Nick Clifton Date: Fri, 05 Jul 2002 07:45:00 -0000 In-Reply-To: <200207041503.g64F3Mj08511@elgar.kettenis.dyndns.org> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00101.txt.bz2 Hi Mark, > After Alan's 2002-06-25 change some tests in GDB's testsuite have been > failing on Linux. Turns out the current code that reads NT_PRXFREG > notes expects note->namesz to be 5, but with the trailing 0, the > length of "LINUX" is 6. Turns out the Linux kernel doesn't include > the trailing 0 in the name size. According to the Systemm V ABI the > trailing 0 should be included, so Alan's change is correct and Linux > is wrong here. But since changing the Linux kernel isn't going to > happen overnight, I propose the attached fix. > > Ok to check this in? > Index: ChangeLog > from Mark Kettenis > > * elf.c (elfcore_grok_note): Fix recognition of NT_PRXFREG notes. Approved - but, please add a comment explaining this situation, so that somebody is not tempted to change the code back. Cheers Nick