[patch] Expand psymtabs when *exact_match is zero

[patch] Expand psymtabs when *exact_match is zero

[Carlos Eduardo Seo]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This addresses the issue discussed here:

http://sourceware.org/ml/gdb/2007-10/msg00017.html

Ok to commit? I can also provide a test case later.

Regards,


- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHGQpIqvq7Aov/qQARAj51AJ4+81ITPywVzd4lburW1AgCip66QgCfSBC0
dHQYq/3jUFpxEqHXrs6+t1s=
=MGT7
-----END PGP SIGNATURE-----

[-- Attachment #2: expand-psymtabs.diff --]
[-- Type: text/x-patch, Size: 777 bytes --]

2007-09-23  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

        * symtab.c (find_line_symtab): scan through psymtabs
	when exact_match is zero.


Index: src/gdb/symtab.c
===================================================================
--- src.orig/gdb/symtab.c
+++ src/gdb/symtab.c
@@ -2280,12 +2280,20 @@ find_line_symtab (struct symtab *symtab,
 
       struct objfile *objfile;
       struct symtab *s;
+      struct partial_symtab *p;
 
       if (best_index >= 0)
 	best = best_linetable->item[best_index].line;
       else
 	best = 0;
 
+      ALL_PSYMTABS (objfile, p)
+      {
+        if (strcmp (symtab->filename, p->filename) != 0)
+          continue;
+        PSYMTAB_TO_SYMTAB (p);
+      }
+
       ALL_SYMTABS (objfile, s)
       {
 	struct linetable *l;

[-- Attachment #3: expand-psymtabs.diff.sig --]
[-- Type: application/octet-stream, Size: 65 bytes --]

Re: [patch] Expand psymtabs when *exact_match is zero

[Jim Blandy]

Carlos Eduardo Seo <cseo at linux.vnet.ibm.com> writes:
> This addresses the issue discussed here:
>
> http://sourceware.org/ml/gdb/2007-10/msg00017.html
>
> Ok to commit? I can also provide a test case later.

This can go in.

I'd rather see psymtabs get expanded and searched only after all
extant symtabs have been checked, but the multi-location breakpoint
code (expand_line_sal) is already going to read them in anyway, so
that horse has already escaped the barn.  We can go catch it if it
turns out to be a problem.

Re: [patch] Expand psymtabs when *exact_match is zero

[Carlos Eduardo Seo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Jim Blandy wrote:
>
> This can go in.
>
> I'd rather see psymtabs get expanded and searched only after all
> extant symtabs have been checked, but the multi-location breakpoint
>  code (expand_line_sal) is already going to read them in anyway, so
>  that horse has already escaped the barn.  We can go catch it if it
>  turns out to be a problem.
Just commited this:

2007-10-24  Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>

        * symtab.c (find_line_symtab): scan through psymtabs
        when exact_match is zero.

Regards,

- --
Carlos Eduardo Seo
Software Engineer
IBM Linux Technology Center
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHH0iCqvq7Aov/qQARApanAJ9G2w+Jf2nrdJs/iNzwevefDuEaJgCfdoen
ZFp892o1pNCp1eRCL2N1pjM=
=AnXx
-----END PGP SIGNATURE-----