From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2880 invoked by alias); 23 Oct 2007 22:26:19 -0000 Received: (qmail 2871 invoked by uid 22791); 23 Oct 2007 22:26:19 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 23 Oct 2007 22:26:16 +0000 Received: (qmail 29884 invoked from network); 23 Oct 2007 22:26:15 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Oct 2007 22:26:15 -0000 To: Carlos Eduardo Seo Cc: GDB Patches Mailing List Subject: Re: [patch] Expand psymtabs when *exact_match is zero References: <47190A49.5020806@linux.vnet.ibm.com> From: Jim Blandy Date: Tue, 23 Oct 2007 23:17:00 -0000 In-Reply-To: <47190A49.5020806@linux.vnet.ibm.com> (Carlos Eduardo Seo's message of "Fri, 19 Oct 2007 17:49:29 -0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00557.txt.bz2 Carlos Eduardo Seo writes: > This addresses the issue discussed here: > > http://sourceware.org/ml/gdb/2007-10/msg00017.html > > Ok to commit? I can also provide a test case later. This can go in. I'd rather see psymtabs get expanded and searched only after all extant symtabs have been checked, but the multi-location breakpoint code (expand_line_sal) is already going to read them in anyway, so that horse has already escaped the barn. We can go catch it if it turns out to be a problem.