From: Sergio Durigan Junior <sergiosdj@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: tromey@redhat.com, sergiodj@redhat.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Implement new features needed for handling SystemTap probes
Date: Tue, 13 Mar 2012 16:06:00 -0000 [thread overview]
Message-ID: <m3399ca3ki.fsf@gmail.com> (raw)
In-Reply-To: <201203130858.q2D8w5fe030670@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Tue, 13 Mar 2012 09:58:05 +0100 (CET)")
On Tuesday, March 13 2012, Mark Kettenis wrote:
>> From: Tom Tromey <tromey@redhat.com>
>> Date: Mon, 12 Mar 2012 08:21:00 -0600
>>
>> >>>>> "Mark" == Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>>
>> Mark> As far as I can tell SystemTap is Linux-specific. So I'd think its
>> Mark> support should go completely in Linux-specific -tdep.c files.
>>
>> sdt.h is really more like an ELF feature.
>
> All evidence I have points towards the functions in i386-tdep.c being
> SystemTap-specific; that's probably why they have "stap" in their name
> ;). They're only used from i386-linux-tdep.c, so it makes much more
> sense to put them there. If somebody ever ports (or reimplements)
> SystemTap for another OS, we can always move them. The same thing
> holds for arm-tdep.c vs. arm-linux-tdep.c of course.
I actually chose to put those functions on i386-tdep.c because they are
used by both {i386,amd64}-linux-tdep.c, and so I thought it would be a
good way to export them. However, I can put them in i386-linux-tdep.c
and export via a new i386-linux-tdep.h, if that's OK.
--
Sergio
next prev parent reply other threads:[~2012-03-13 16:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 20:29 [PATCH 0/3] Implement support for SystemTap probes on userspace Sergio Durigan Junior
2012-03-09 20:32 ` [PATCH 1/3] Refactor internal variable mechanism Sergio Durigan Junior
2012-03-09 21:03 ` Tom Tromey
2012-03-10 4:02 ` Sergio Durigan Junior
2012-03-09 20:34 ` [PATCH 3/3] Use longjmp and exception probes when available Sergio Durigan Junior
2012-03-09 20:34 ` [PATCH 2/3] Implement new features needed for handling SystemTap probes Sergio Durigan Junior
2012-03-10 8:38 ` Eli Zaretskii
2012-03-10 16:56 ` Mark Kettenis
2012-03-12 15:11 ` Tom Tromey
2012-03-13 8:58 ` Mark Kettenis
2012-03-13 16:06 ` Sergio Durigan Junior [this message]
2012-03-15 20:44 ` Tom Tromey
2012-03-16 14:52 ` Mark Kettenis
2012-03-16 18:17 ` Tom Tromey
2012-03-10 19:22 ` Jan Kratochvil
2012-03-12 20:37 ` Tom Tromey
2012-03-12 23:15 ` Jan Kratochvil
2012-03-15 15:40 ` Pedro Alves
2012-03-15 15:36 ` Pedro Alves
2012-03-15 20:50 ` Tom Tromey
2012-03-09 21:15 ` [PATCH 0/3] Implement support for SystemTap probes on userspace Tom Tromey
2012-03-10 3:51 ` Sergio Durigan Junior
2012-03-10 7:55 ` Eli Zaretskii
2012-03-10 8:55 ` Jan Kratochvil
2012-03-10 9:06 ` Eli Zaretskii
2012-03-10 15:52 ` Sergio Durigan Junior
2012-03-12 19:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3399ca3ki.fsf@gmail.com \
--to=sergiosdj@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox