Re: [PATCH 0/3] Implement support for SystemTap probes on userspace

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Sat, 10 Mar 2012 08:55:05 +0100, Eli Zaretskii wrote:
> >     sergio@psique ~/work/src/git/stap-patches/build-64/gdb $ ./gdb -q /tmp/stap-example 
> >     (gdb) info probes
> >     Provider   Name       Where               Semaphore           Object                         
> >     teste      m4         0x0000000000400505  0x00000000006009f8  /tmp/stap-example              
> >     teste      ps         0x00000000004004cd  0x00000000006009fc  /tmp/stap-example              
> >     teste      two        0x0000000000400484  0x00000000006009f6  /tmp/stap-example              
> >     teste      two        0x0000000000400497  0x00000000006009f6  /tmp/stap-example              
> >     teste      user       0x00000000004004ad  0x00000000006009f4  /tmp/stap-example              
> 
> May I suggest that the new command be called "info stap-probes"
> instead?  IMO, "probe" is much too general, and may conflict in the
> future with some other feature that uses similar facilities or
> terminology.

There can be "info probes stap" and "info probes foo" in the future with "info
probes" calling all the existing probe backends.  Like "show" shows all
variables. (I have also "info auto-load" in this still but it has not yet been
posted.)


> > As you can see above, there are 5 probes in the binary.  We can now ask
> > GDB to put a breakpoint in a probe, by using the new option `-p' or
> > `-probe' in the `break' command:
> > 
> >     (gdb) b -probe m4
> >     Breakpoint 1 at 0x400505
> 
> Again, either "break -stap-probe" or even just "break -stap" would be
> better, IMO.

Again -probe may try to find that probe in all the probe backends, later
extensible by -probe-stap and -probe-foo?


Before a real review, so it is a bikeshed.


Jan