RFA: don't swap void builtin type

RFA: don't swap void builtin type

[Jim Blandy]

I can't see any reason we need to swap out builtin_type_void while
changing architectures, and it is nice to have as many types available
in as many circumstances as possible.

gdb/ChangeLog:
2006-12-04  Jim Blandy  <jimb@codesourcery.com>

	* gdbtypes.c (built_gdbtypes): Don't set builtin_type_void here.
	(_initialize_gdbtypes): Do it here, and don't swap it when the
	architecture changes.

Index: gdb-trunk/gdb/gdbtypes.c
===================================================================
--- gdb-trunk.orig/gdb/gdbtypes.c	2006-12-04 13:40:30.000000000 -0800
+++ gdb-trunk/gdb/gdbtypes.c	2006-12-04 13:55:22.000000000 -0800
@@ -3299,10 +3299,6 @@
 static void
 build_gdbtypes (void)
 {
-  builtin_type_void =
-    init_type (TYPE_CODE_VOID, 1,
-	       0,
-	       "void", (struct objfile *) NULL);
   builtin_type_char =
     init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
 	       (TYPE_FLAG_NOSIGN
@@ -3652,6 +3648,10 @@
 {
   struct cmd_list_element *c;
 
+  builtin_type_void =
+    init_type (TYPE_CODE_VOID, 1,
+	       0,
+	       "void", (struct objfile *) NULL);
   builtin_type_int0 =
     init_type (TYPE_CODE_INT, 0 / 8,
 	       0,
@@ -3704,7 +3704,6 @@
   /* FIXME - For the moment, handle types by swapping them in and out.
      Should be using the per-architecture data-pointer and a large
      struct. */
-  DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_void);
   DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_char);
   DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_short);
   DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_int);

Re: RFA: don't swap void builtin type

[Daniel Jacobowitz]

On Mon, Dec 04, 2006 at 02:06:31PM -0800, Jim Blandy wrote:
> 
> I can't see any reason we need to swap out builtin_type_void while
> changing architectures, and it is nice to have as many types available
> in as many circumstances as possible.
> 
> gdb/ChangeLog:
> 2006-12-04  Jim Blandy  <jimb@codesourcery.com>
> 
> 	* gdbtypes.c (built_gdbtypes): Don't set builtin_type_void here.
> 	(_initialize_gdbtypes): Do it here, and don't swap it when the
> 	architecture changes.
> 

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: RFA: don't swap void builtin type

[Jim Blandy]

Daniel Jacobowitz <drow@false.org> writes:
> On Mon, Dec 04, 2006 at 02:06:31PM -0800, Jim Blandy wrote:
>> 
>> I can't see any reason we need to swap out builtin_type_void while
>> changing architectures, and it is nice to have as many types available
>> in as many circumstances as possible.
>> 
>> gdb/ChangeLog:
>> 2006-12-04  Jim Blandy  <jimb@codesourcery.com>
>> 
>> 	* gdbtypes.c (built_gdbtypes): Don't set builtin_type_void here.
>> 	(_initialize_gdbtypes): Do it here, and don't swap it when the
>> 	architecture changes.
>> 
>
> OK.

Committed, thanks.