From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: RFA: don't swap void builtin type
Date: Mon, 04 Dec 2006 22:05:00 -0000 [thread overview]
Message-ID: <m31wnfpb88.fsf@codesourcery.com> (raw)
I can't see any reason we need to swap out builtin_type_void while
changing architectures, and it is nice to have as many types available
in as many circumstances as possible.
gdb/ChangeLog:
2006-12-04 Jim Blandy <jimb@codesourcery.com>
* gdbtypes.c (built_gdbtypes): Don't set builtin_type_void here.
(_initialize_gdbtypes): Do it here, and don't swap it when the
architecture changes.
Index: gdb-trunk/gdb/gdbtypes.c
===================================================================
--- gdb-trunk.orig/gdb/gdbtypes.c 2006-12-04 13:40:30.000000000 -0800
+++ gdb-trunk/gdb/gdbtypes.c 2006-12-04 13:55:22.000000000 -0800
@@ -3299,10 +3299,6 @@
static void
build_gdbtypes (void)
{
- builtin_type_void =
- init_type (TYPE_CODE_VOID, 1,
- 0,
- "void", (struct objfile *) NULL);
builtin_type_char =
init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
(TYPE_FLAG_NOSIGN
@@ -3652,6 +3648,10 @@
{
struct cmd_list_element *c;
+ builtin_type_void =
+ init_type (TYPE_CODE_VOID, 1,
+ 0,
+ "void", (struct objfile *) NULL);
builtin_type_int0 =
init_type (TYPE_CODE_INT, 0 / 8,
0,
@@ -3704,7 +3704,6 @@
/* FIXME - For the moment, handle types by swapping them in and out.
Should be using the per-architecture data-pointer and a large
struct. */
- DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_void);
DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_char);
DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_short);
DEPRECATED_REGISTER_GDBARCH_SWAP (builtin_type_int);
next reply other threads:[~2006-12-04 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 22:05 Jim Blandy [this message]
2006-12-05 20:50 ` Daniel Jacobowitz
2006-12-06 0:57 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31wnfpb88.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox