Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Make sym_read routines handle separate debug files
Date: Tue, 08 Dec 2009 16:54:00 -0000	[thread overview]
Message-ID: <m31vj576gp.fsf@fleche.redhat.com> (raw)
In-Reply-To: <DA892454-09F0-43C0-A813-EDD8EE33FAA8@adacore.com> (Tristan 	Gingold's message of "Tue, 8 Dec 2009 11:57:48 +0100")

>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:

Tristan> latest version of the patch.  I have inserted a gdb_assert in
Tristan> symbol_file_add_separate and fixed the comment in
Tristan> reread_symbols.

Thanks.

I found one more little problem, nothing major.

Tristan> @@ -947,8 +943,6 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd,
[...]
Tristan>    discard_cleanups (my_cleanups);
 
Tristan> -  if (addrs)
Tristan> -    {
Tristan> -      orig_addrs = copy_section_addr_info (addrs);
Tristan> -      make_cleanup_free_section_addr_info (orig_addrs);
Tristan> -    }

I think this function has a latent bug.  It calls
discard_cleanups(my_cleanups), then makes a new cleanup which isn't
assigned anywhere.  Then later it calls do_cleanups(my_cleanups).

Could you remove the do_cleanups?

This patch is ok with that change.  Thanks again.

Tom


  reply	other threads:[~2009-12-08 16:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 12:48 Tristan Gingold
2009-12-04 18:02 ` Tom Tromey
2009-12-07 10:50   ` Tristan Gingold
2009-12-07 20:13     ` Tom Tromey
2009-12-07 20:33       ` Daniel Jacobowitz
2009-12-07 21:22         ` Tom Tromey
2009-12-08 10:57       ` Tristan Gingold
2009-12-08 16:54         ` Tom Tromey [this message]
2009-12-09 13:45           ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31vj576gp.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox