From: Tristan Gingold <gingold@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Make sym_read routines handle separate debug files
Date: Wed, 09 Dec 2009 13:45:00 -0000 [thread overview]
Message-ID: <E8023685-CB32-4519-B079-4897B1146911@adacore.com> (raw)
In-Reply-To: <m31vj576gp.fsf@fleche.redhat.com>
On Dec 8, 2009, at 5:53 PM, Tom Tromey wrote:
> Tristan> @@ -947,8 +943,6 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd,
> [...]
> Tristan> discard_cleanups (my_cleanups);
>
> Tristan> - if (addrs)
> Tristan> - {
> Tristan> - orig_addrs = copy_section_addr_info (addrs);
> Tristan> - make_cleanup_free_section_addr_info (orig_addrs);
> Tristan> - }
>
> I think this function has a latent bug. It calls
> discard_cleanups(my_cleanups), then makes a new cleanup which isn't
> assigned anywhere. Then later it calls do_cleanups(my_cleanups).
>
> Could you remove the do_cleanups?
Sure. Indeed, it is not necessary anymore.
> This patch is ok with that change. Thanks again.
Committed. Thank you for the reviews.
Tristan.
prev parent reply other threads:[~2009-12-09 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 12:48 Tristan Gingold
2009-12-04 18:02 ` Tom Tromey
2009-12-07 10:50 ` Tristan Gingold
2009-12-07 20:13 ` Tom Tromey
2009-12-07 20:33 ` Daniel Jacobowitz
2009-12-07 21:22 ` Tom Tromey
2009-12-08 10:57 ` Tristan Gingold
2009-12-08 16:54 ` Tom Tromey
2009-12-09 13:45 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E8023685-CB32-4519-B079-4897B1146911@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox