From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68834-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12795 invoked by alias); 9 Dec 2009 13:45:53 -0000
Received: (qmail 12782 invoked by uid 22791); 9 Dec 2009 13:45:50 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Dec 2009 13:45:46 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 1639E29001C; 	Wed,  9 Dec 2009 14:45:44 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1]) 	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id jMdr+SpYVgp5; Wed,  9 Dec 2009 14:45:43 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) 	(using TLSv1 with cipher AES128-SHA (128/128 bits)) 	(No client certificate requested) 	by mel.act-europe.fr (Postfix) with ESMTP id 7B76329000C; 	Wed,  9 Dec 2009 14:45:43 +0100 (CET)
Subject: Re: [RFA] Make sym_read routines handle separate debug files
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <m31vj576gp.fsf@fleche.redhat.com>
Date: Wed, 09 Dec 2009 13:45:00 -0000
Cc: gdb-patches@sourceware.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E8023685-CB32-4519-B079-4897B1146911@adacore.com>
References: <20091204124838.GA5764@ulanbator.act-europe.fr> <m38wdifwj1.fsf@fleche.redhat.com> <2CC5EFB8-A1BC-4025-9136-E8FA344B2C04@adacore.com> <m3638ia6ge.fsf@fleche.redhat.com> <DA892454-09F0-43C0-A813-EDD8EE33FAA8@adacore.com> <m31vj576gp.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00132.txt.bz2


On Dec 8, 2009, at 5:53 PM, Tom Tromey wrote:

> Tristan> @@ -947,8 +943,6 @@ symbol_file_add_with_addrs_or_offsets (bfd *=
abfd,
> [...]
> Tristan>    discard_cleanups (my_cleanups);
>=20
> Tristan> -  if (addrs)
> Tristan> -    {
> Tristan> -      orig_addrs =3D copy_section_addr_info (addrs);
> Tristan> -      make_cleanup_free_section_addr_info (orig_addrs);
> Tristan> -    }
>=20
> I think this function has a latent bug.  It calls
> discard_cleanups(my_cleanups), then makes a new cleanup which isn't
> assigned anywhere.  Then later it calls do_cleanups(my_cleanups).
>=20
> Could you remove the do_cleanups?

Sure.  Indeed, it is not necessary anymore.

> This patch is ok with that change.  Thanks again.

Committed.  Thank you for the reviews.

Tristan.