From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68821-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4322 invoked by alias); 8 Dec 2009 16:54:00 -0000
Received: (qmail 4314 invoked by uid 22791); 8 Dec 2009 16:53:58 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Dec 2009 16:53:53 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB8GrSNC010174 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Tue, 8 Dec 2009 11:53:28 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB8GrRLK024048; 	Tue, 8 Dec 2009 11:53:28 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nB8GrQf6024135; 	Tue, 8 Dec 2009 11:53:27 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 800063782A2; Tue,  8 Dec 2009 09:53:26 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Make sym_read routines handle separate debug files
References: <20091204124838.GA5764@ulanbator.act-europe.fr> 	<m38wdifwj1.fsf@fleche.redhat.com> 	<2CC5EFB8-A1BC-4025-9136-E8FA344B2C04@adacore.com> 	<m3638ia6ge.fsf@fleche.redhat.com> 	<DA892454-09F0-43C0-A813-EDD8EE33FAA8@adacore.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 08 Dec 2009 16:54:00 -0000
In-Reply-To: <DA892454-09F0-43C0-A813-EDD8EE33FAA8@adacore.com> (Tristan 	Gingold's message of "Tue, 8 Dec 2009 11:57:48 +0100")
Message-ID: <m31vj576gp.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00119.txt.bz2

>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:

Tristan> latest version of the patch.  I have inserted a gdb_assert in
Tristan> symbol_file_add_separate and fixed the comment in
Tristan> reread_symbols.

Thanks.

I found one more little problem, nothing major.

Tristan> @@ -947,8 +943,6 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd,
[...]
Tristan>    discard_cleanups (my_cleanups);
 
Tristan> -  if (addrs)
Tristan> -    {
Tristan> -      orig_addrs = copy_section_addr_info (addrs);
Tristan> -      make_cleanup_free_section_addr_info (orig_addrs);
Tristan> -    }

I think this function has a latent bug.  It calls
discard_cleanups(my_cleanups), then makes a new cleanup which isn't
assigned anywhere.  Then later it calls do_cleanups(my_cleanups).

Could you remove the do_cleanups?

This patch is ok with that change.  Thanks again.

Tom