From: Tom Tromey <tromey@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch for PR 9399
Date: Thu, 10 Dec 2009 18:55:00 -0000 [thread overview]
Message-ID: <m31vj24q1d.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B213EDB.4020609@redhat.com> (Chris Moller's message of "Thu, 10 Dec 2009 13:32:59 -0500")
>>>>> "Chris" == Chris Moller <cmoller@redhat.com> writes:
Chris> + if ((TYPE_NAME (t1) != NULL)
Chris> + && (TYPE_NAME (t2) != NULL)
There are too many parens here.
It should be
if (TYPE_NAME (t1) != NULL
&& TYPE_NAME (t2) != NULL
...
You don't have to resubmit this, just fix it and check it in.
thanks,
Tom
prev parent reply other threads:[~2009-12-10 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 13:32 Chris Moller
2009-12-09 14:05 ` Daniel Jacobowitz
2009-12-09 15:10 ` Chris Moller
2009-12-10 18:41 ` Daniel Jacobowitz
2009-12-10 19:04 ` Tom Tromey
2009-12-10 19:09 ` Chris Moller
2009-12-10 19:13 ` Daniel Jacobowitz
2009-12-10 16:59 ` Tom Tromey
2009-12-10 18:33 ` Chris Moller
2009-12-10 18:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vj24q1d.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox