From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Chris Moller <cmoller@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Patch for PR 9399
Date: Thu, 10 Dec 2009 19:13:00 -0000 [thread overview]
Message-ID: <20091210191340.GA19057@caradoc.them.org> (raw)
In-Reply-To: <m3vdge3b2u.fsf@fleche.redhat.com>
No, I think the patch is fine to go in.
On Thu, Dec 10, 2009 at 12:04:09PM -0700, Tom Tromey wrote:
> I think from value_cast_structs:
>
> /* Downcasting: look in the type of the target to see if it contains the
> type of the source as a superclass. If so, we'll need to
> offset the pointer rather than just change its type.
> FIXME: This fails silently with virtual inheritance. */
>
> ... but this doesn't fail silently, it tries to dereference NULL, due to
> the use of value_zero. IIRC.
I see now. This is just lame. We should be able to ask this question
about the static type of the target - possibly the easiest way to do
that is to special-case the NULL vptr. I probably wrote that.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-12-10 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 13:32 Chris Moller
2009-12-09 14:05 ` Daniel Jacobowitz
2009-12-09 15:10 ` Chris Moller
2009-12-10 18:41 ` Daniel Jacobowitz
2009-12-10 19:04 ` Tom Tromey
2009-12-10 19:09 ` Chris Moller
2009-12-10 19:13 ` Daniel Jacobowitz [this message]
2009-12-10 16:59 ` Tom Tromey
2009-12-10 18:33 ` Chris Moller
2009-12-10 18:55 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210191340.GA19057@caradoc.them.org \
--to=drow@false.org \
--cc=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox