From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25407 invoked by alias); 10 Dec 2009 18:55:52 -0000 Received: (qmail 25397 invoked by uid 22791); 10 Dec 2009 18:55:51 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Dec 2009 18:55:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBAItjG5026169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Dec 2009 13:55:45 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBAItiqS029275; Thu, 10 Dec 2009 13:55:44 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBAIthcF027687; Thu, 10 Dec 2009 13:55:43 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id C5CAE3782A3; Thu, 10 Dec 2009 11:55:42 -0700 (MST) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: Patch for PR 9399 References: <4B1FA6F2.1060105@redhat.com> <4B213EDB.4020609@redhat.com> Reply-To: Tom Tromey Date: Thu, 10 Dec 2009 18:55:00 -0000 In-Reply-To: <4B213EDB.4020609@redhat.com> (Chris Moller's message of "Thu, 10 Dec 2009 13:32:59 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00146.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> + if ((TYPE_NAME (t1) != NULL) Chris> + && (TYPE_NAME (t2) != NULL) There are too many parens here. It should be if (TYPE_NAME (t1) != NULL && TYPE_NAME (t2) != NULL ... You don't have to resubmit this, just fix it and check it in. thanks, Tom