From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, ktietz70@googlemail.com
Subject: Re: [RFA/commit/Win64] Remove new extra leading underscore in symbol name
Date: Fri, 18 Jun 2010 17:40:00 -0000 [thread overview]
Message-ID: <m31vc4nssb.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1276813536-31761-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 17 Jun 2010 15:25:36 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> 2010-06-17 Joel Brobecker <brobecker@adacore.com>
Joel> gdb/
Joel> * coffread.c (getsymname): Skip the leading underscore on pe64.
I don't know anything about this target, but the binutils patch includes
a --enable-leading-mingw64-underscores option...
Joel> + const char *target = bfd_get_target (symfile_bfd);
Joel> + const int is_pe64 = (strcmp (target, "pe-x86-64") == 0
Joel> + || strcmp (target, "pei-x86-64") == 0);
...so maybe instead of looking at the target name, it would be better to
use bfd_get_target_info here?
Tom
next prev parent reply other threads:[~2010-06-18 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 22:25 Joel Brobecker
2010-06-18 17:40 ` Tom Tromey [this message]
2010-06-24 18:23 ` Joel Brobecker
2010-06-24 18:31 ` Tom Tromey
2010-06-24 18:42 ` Pedro Alves
2010-06-24 19:00 ` Joel Brobecker
2010-06-24 19:25 ` Pedro Alves
2010-06-24 20:12 ` Kai Tietz
2010-06-24 20:32 ` Joel Brobecker
2010-06-24 20:41 ` Kai Tietz
2010-06-25 8:33 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vc4nssb.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox