Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>,
	ktietz70@googlemail.com
Subject: Re: [RFA/commit/Win64] Remove new extra leading underscore in symbol name
Date: Thu, 24 Jun 2010 19:00:00 -0000	[thread overview]
Message-ID: <20100624190021.GJ2595@adacore.com> (raw)
In-Reply-To: <201006241942.32722.pedro@codesourcery.com>

> I'm confused on your change.  It sounds like you're using a debugger
> that postdates the change to default to not output underscores on
> win64, with a compiler that still outputs the underscores.  What
> happens when you update your compiler?  I expect your patch to break
> binaries produced by a compiler that also doesn't output
> underscores anymore on c symbols, as mingw64's.  Isn't that so?

You might be right - I haven't tried to build an updated compiler since
building one on MinGW is a big problem for someone like me who almost
never works on Windows and is just not setup for it.

> I don't think either a bfd_get_target or bfd_get_target_info check
> will always get you a right answer, since those essentially are
> returning hardcoded answers in bfd, not how the binaries were
> built.  Am I wrong?

No, you're probably right. I was slowly realizing this while I was
updating the comment I wrote in the previous patch. The problem is:
what's the right way to detect how the binary was built? Right now,
the bfd change is a major incompatibility nightmare since minimal
symbols and symbols no longer have the same name.  GDB needs to be able
to support both (IMO).

-- 
Joel


  reply	other threads:[~2010-06-24 19:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 22:25 Joel Brobecker
2010-06-18 17:40 ` Tom Tromey
2010-06-24 18:23   ` Joel Brobecker
2010-06-24 18:31     ` Tom Tromey
2010-06-24 18:42     ` Pedro Alves
2010-06-24 19:00       ` Joel Brobecker [this message]
2010-06-24 19:25         ` Pedro Alves
2010-06-24 20:12           ` Kai Tietz
2010-06-24 20:32             ` Joel Brobecker
2010-06-24 20:41               ` Kai Tietz
2010-06-25  8:33 ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100624190021.GJ2595@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ktietz70@googlemail.com \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox