From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16775 invoked by alias); 18 Jun 2010 17:40:50 -0000 Received: (qmail 16762 invoked by uid 22791); 18 Jun 2010 17:40:48 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jun 2010 17:40:42 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5IHeOTL030235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Jun 2010 13:40:24 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5IHeOSL031385; Fri, 18 Jun 2010 13:40:24 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5IHeN9N013394; Fri, 18 Jun 2010 13:40:23 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id F0FDA37814A; Fri, 18 Jun 2010 11:40:21 -0600 (MDT) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org, ktietz70@googlemail.com Subject: Re: [RFA/commit/Win64] Remove new extra leading underscore in symbol name References: <1276813536-31761-1-git-send-email-brobecker@adacore.com> Reply-To: tromey@redhat.com Date: Fri, 18 Jun 2010 17:40:00 -0000 In-Reply-To: <1276813536-31761-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 17 Jun 2010 15:25:36 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00411.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> 2010-06-17 Joel Brobecker Joel> gdb/ Joel> * coffread.c (getsymname): Skip the leading underscore on pe64. I don't know anything about this target, but the binutils patch includes a --enable-leading-mingw64-underscores option... Joel> + const char *target = bfd_get_target (symfile_bfd); Joel> + const int is_pe64 = (strcmp (target, "pe-x86-64") == 0 Joel> + || strcmp (target, "pei-x86-64") == 0); ...so maybe instead of looking at the target name, it would be better to use bfd_get_target_info here? Tom