From: Andreas Schwab <schwab@linux-m68k.org>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix for gdb.parameter('architecture') returning empty string
Date: Sun, 14 Oct 2012 07:53:00 -0000 [thread overview]
Message-ID: <m2zk3pv69n.fsf@linux-m68k.org> (raw)
In-Reply-To: <CAGyQ6gzRaxiQyM71_RaX7yRiUWYGrTUpmNKpd92=MRSxShJAgQ@mail.gmail.com> (Siva Chandra's message of "Sat, 13 Oct 2012 16:43:51 -0700")
Siva Chandra <sivachandra@google.com> writes:
> @@ -274,19 +275,13 @@ show_endian (struct ui_file *file, int f
> const char *value)
> {
> if (target_byte_order_user == BFD_ENDIAN_UNKNOWN)
> - if (gdbarch_byte_order (get_current_arch ()) == BFD_ENDIAN_BIG)
> fprintf_unfiltered (file, _("The target endianness is set automatically "
> - "(currently big endian)\n"));
> - else
> - fprintf_unfiltered (file, _("The target endianness is set automatically "
> - "(currently little endian)\n"));
> + "(currently %s endian)\n"),
> + endian_string);
> else
> - if (target_byte_order_user == BFD_ENDIAN_BIG)
> - fprintf_unfiltered (file,
> - _("The target is assumed to be big endian\n"));
> - else
> fprintf_unfiltered (file,
> - _("The target is assumed to be little endian\n"));
> + _("The target is assumed to be %s endian\n"),
> + endian_string);
This is bad for i18n, since big/little can no longer be translated.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-10-14 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 23:43 Siva Chandra
2012-10-14 7:53 ` Andreas Schwab [this message]
2012-10-14 8:37 ` Siva Chandra
2012-10-22 7:16 ` Siva Chandra
2012-11-01 20:19 ` Tom Tromey
2012-11-02 13:44 ` Siva Chandra
2012-11-02 16:59 ` Tom Tromey
2012-11-02 18:45 ` Siva Chandra
2012-11-02 19:52 ` Tom Tromey
2012-11-05 10:39 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zk3pv69n.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox