From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95194-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10941 invoked by alias); 14 Oct 2012 07:53:52 -0000
Received: (qmail 10933 invoked by uid 22791); 14 Oct 2012 07:53:52 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 14 Oct 2012 07:53:45 +0000
Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180])	by mail-out.m-online.net (Postfix) with ESMTP id 3XfZm83Pkkz3hhVP;	Sun, 14 Oct 2012 09:53:44 +0200 (CEST)
X-Auth-Info: qy5fRvhprxg8gltkCtkD6ASj3c30RVZJ3qrQo6Lb/4c=
Received: from linux.local (ppp-93-104-139-87.dynamic.mnet-online.de [93.104.139.87])	by mail.mnet-online.de (Postfix) with ESMTPA id 3XfZm82Vdyzbbfq;	Sun, 14 Oct 2012 09:53:44 +0200 (CEST)
Received: by linux.local (Postfix, from userid 501)	id 0D8031E5326; Sun, 14 Oct 2012 09:53:41 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix for gdb.parameter('architecture') returning empty string
References: <CAGyQ6gzRaxiQyM71_RaX7yRiUWYGrTUpmNKpd92=MRSxShJAgQ@mail.gmail.com>
X-Yow: That's a decision that can only be made between you & SY SPERLING!!
Date: Sun, 14 Oct 2012 07:53:00 -0000
In-Reply-To: <CAGyQ6gzRaxiQyM71_RaX7yRiUWYGrTUpmNKpd92=MRSxShJAgQ@mail.gmail.com>	(Siva Chandra's message of "Sat, 13 Oct 2012 16:43:51 -0700")
Message-ID: <m2zk3pv69n.fsf@linux-m68k.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00202.txt.bz2

Siva Chandra <sivachandra@google.com> writes:

> @@ -274,19 +275,13 @@ show_endian (struct ui_file *file, int f
>  	     const char *value)
>  {
>    if (target_byte_order_user == BFD_ENDIAN_UNKNOWN)
> -    if (gdbarch_byte_order (get_current_arch ()) == BFD_ENDIAN_BIG)
>        fprintf_unfiltered (file, _("The target endianness is set automatically "
> -				  "(currently big endian)\n"));
> -    else
> -      fprintf_unfiltered (file, _("The target endianness is set automatically "
> -				  "(currently little endian)\n"));
> +				  "(currently %s endian)\n"),
> +                          endian_string);
>    else
> -    if (target_byte_order_user == BFD_ENDIAN_BIG)
> -      fprintf_unfiltered (file,
> -			  _("The target is assumed to be big endian\n"));
> -    else
>        fprintf_unfiltered (file,
> -			  _("The target is assumed to be little endian\n"));
> +			  _("The target is assumed to be %s endian\n"),
> +                          endian_string);

This is bad for i18n, since big/little can no longer be translated.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."