From: Andreas Schwab <schwab@linux-m68k.org>
To: Svante Signell <svante.signell@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Please define thread_info as struct thread_info (and other stuff)
Date: Sun, 16 Dec 2018 09:20:00 -0000 [thread overview]
Message-ID: <m2y38pddzs.fsf@linux-m68k.org> (raw)
In-Reply-To: <c43ca8d60ab8880408033a21901d544f3ec9de57.camel@gmail.com> (Svante Signell's message of "Sat, 15 Dec 2018 20:36:33 +0100")
On Dez 15 2018, Svante Signell <svante.signell@gmail.com> wrote:
> Index: gdb-8.2/gdb/regcache.h
> ===================================================================
> --- gdb-8.2.orig/gdb/regcache.h
> +++ gdb-8.2/gdb/regcache.h
> @@ -21,6 +21,7 @@
> #define REGCACHE_H
>
> #include "common-regcache.h"
> +#include "function-view.h"
> #include <forward_list>
>
> struct regcache;
> @@ -32,7 +33,7 @@ extern struct regcache *get_current_regc
> extern struct regcache *get_thread_regcache (ptid_t ptid);
>
> /* Get the regcache of THREAD. */
> -extern struct regcache *get_thread_regcache (thread_info *thread);
> +extern struct regcache *get_thread_regcache (struct thread_info *thread);
>
> extern struct regcache *get_thread_arch_regcache (ptid_t, struct gdbarch *);
> extern struct regcache *get_thread_arch_aspace_regcache (ptid_t,
> @@ -436,7 +437,7 @@ extern void registers_changed_ptid (ptid
>
> /* Indicate that registers of THREAD may have changed, so invalidate
> the cache. */
> -extern void registers_changed_thread (thread_info *thread);
> +extern void registers_changed_thread (struct thread_info *thread);
>
> /* An abstract base class for register dump. */
Try adding a forward declaration of struct thead_info. Note that
config/i386/nm-i386gnu.h includes "regcache.h", making it unique among
the nm.h files.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2018-12-16 9:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 19:36 Svante Signell
2018-12-15 22:48 ` Tom Tromey
2018-12-15 23:01 ` Svante Signell
2018-12-16 4:31 ` Simon Marchi
2018-12-16 5:14 ` Svante Signell
2018-12-16 6:02 ` Simon Marchi
2018-12-16 16:22 ` Tom Tromey
2018-12-16 9:20 ` Andreas Schwab [this message]
2018-12-16 19:08 ` Svante Signell
2018-12-16 23:10 ` Tom Tromey
2018-12-17 20:51 ` Svante Signell
2018-12-17 21:41 ` John Baldwin
2019-02-14 15:16 ` Thomas Schwinge
2018-12-20 13:31 ` Svante Signell
2018-12-20 22:34 ` Tom Tromey
2018-12-20 23:26 ` Simon Marchi
2018-12-24 21:51 ` Tom Tromey
2019-01-12 18:37 ` Svante Signell
2019-01-12 20:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y38pddzs.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=svante.signell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox