From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28381 invoked by alias); 16 Dec 2018 09:20:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28369 invoked by uid 89); 16 Dec 2018 09:20:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Dec 2018 09:20:48 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43Hf0F68jzz1qwf4; Sun, 16 Dec 2018 10:20:45 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43Hf0F5tcMz1qsZp; Sun, 16 Dec 2018 10:20:45 +0100 (CET) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id JrO-tsCBrZYL; Sun, 16 Dec 2018 10:20:44 +0100 (CET) Received: from linux.local (ppp-188-174-151-118.dynamic.mnet-online.de [188.174.151.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 16 Dec 2018 10:20:44 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id 27C9A1E5857; Sun, 16 Dec 2018 10:20:40 +0100 (CET) From: Andreas Schwab To: Svante Signell Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Please define thread_info as struct thread_info (and other stuff) References: X-Yow: .. are the STEWED PRUNES still in the HAIR DRYER? Date: Sun, 16 Dec 2018 09:20:00 -0000 In-Reply-To: (Svante Signell's message of "Sat, 15 Dec 2018 20:36:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00181.txt.bz2 On Dez 15 2018, Svante Signell wrote: > Index: gdb-8.2/gdb/regcache.h > =================================================================== > --- gdb-8.2.orig/gdb/regcache.h > +++ gdb-8.2/gdb/regcache.h > @@ -21,6 +21,7 @@ > #define REGCACHE_H > > #include "common-regcache.h" > +#include "function-view.h" > #include > > struct regcache; > @@ -32,7 +33,7 @@ extern struct regcache *get_current_regc > extern struct regcache *get_thread_regcache (ptid_t ptid); > > /* Get the regcache of THREAD. */ > -extern struct regcache *get_thread_regcache (thread_info *thread); > +extern struct regcache *get_thread_regcache (struct thread_info *thread); > > extern struct regcache *get_thread_arch_regcache (ptid_t, struct gdbarch *); > extern struct regcache *get_thread_arch_aspace_regcache (ptid_t, > @@ -436,7 +437,7 @@ extern void registers_changed_ptid (ptid > > /* Indicate that registers of THREAD may have changed, so invalidate > the cache. */ > -extern void registers_changed_thread (thread_info *thread); > +extern void registers_changed_thread (struct thread_info *thread); > > /* An abstract base class for register dump. */ Try adding a forward declaration of struct thead_info. Note that config/i386/nm-i386gnu.h includes "regcache.h", making it unique among the nm.h files. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."