From: Tom Tromey <tom@tromey.com>
To: Svante Signell <svante.signell@gmail.com>
Cc: Tom Tromey <tom@tromey.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Please define thread_info as struct thread_info (and other stuff)
Date: Thu, 20 Dec 2018 22:34:00 -0000 [thread overview]
Message-ID: <878t0j4ykk.fsf@tromey.com> (raw)
In-Reply-To: <fcf93ed582163972303379c6a3f05e89a022475f.camel@gmail.com> (Svante Signell's message of "Thu, 20 Dec 2018 14:32:22 +0100")
>>>>> "Svante" == Svante Signell <svante.signell@gmail.com> writes:
Svante> Seems like nothing is happening so far. Did you expect me to
Svante> take action on this issue? Or is this a low-prio problem for
Svante> you, Hurd being a second class citizen?
It's not so much second-class as that the usual way gdb development
works is that ports need maintainers, and the current contributors are
pretty busy and/or have other interests.
I took a quick look at it and one question I have is whether
nm-i386gnu.h really needs to include any of the headers it does. defs.h
already includes unistd.h, and regcache.h should probably not be needed;
and removing the mach includes would at least reduce the number of spots
needing the "struct". Could you try removing these lines?
Also I happened to notice that file declares gnu_target_pid_to_str --
but I didn't see a definition. So perhaps that could be removed as
well.
thanks,
Tom
next prev parent reply other threads:[~2018-12-20 22:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 19:36 Svante Signell
2018-12-15 22:48 ` Tom Tromey
2018-12-15 23:01 ` Svante Signell
2018-12-16 4:31 ` Simon Marchi
2018-12-16 5:14 ` Svante Signell
2018-12-16 6:02 ` Simon Marchi
2018-12-16 16:22 ` Tom Tromey
2018-12-16 9:20 ` Andreas Schwab
2018-12-16 19:08 ` Svante Signell
2018-12-16 23:10 ` Tom Tromey
2018-12-17 20:51 ` Svante Signell
2018-12-17 21:41 ` John Baldwin
2019-02-14 15:16 ` Thomas Schwinge
2018-12-20 13:31 ` Svante Signell
2018-12-20 22:34 ` Tom Tromey [this message]
2018-12-20 23:26 ` Simon Marchi
2018-12-24 21:51 ` Tom Tromey
2019-01-12 18:37 ` Svante Signell
2019-01-12 20:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t0j4ykk.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
--cc=simark@simark.ca \
--cc=svante.signell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox