Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFA] [1/2] auto-loading scripts from .debug_gdb_scripts section
Date: Wed, 21 Apr 2010 21:54:00 -0000	[thread overview]
Message-ID: <m2xe394668d1004211454qf3b0f7fajcd740a3022662e93@mail.gmail.com> (raw)
In-Reply-To: <83eii84k4c.fsf@gnu.org>

On Wed, Apr 21, 2010 at 1:37 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Wed, 21 Apr 2010 12:23:16 -0700
>> From: Doug Evans <dje@google.com>
>>
>> I've applied the requested doc changes, except that Auto-loading is
>> still moved up one level, moved from node Python API to node Python.
>
> Thanks.
>
>> +If this file does not exist, and if the parameter
>> +@code{debug-file-directory} is set (@pxref{Separate Debug Files}),
>> +then @value{GDBN} will use for its each separated directory component
>> +@code{component} the file named @file{@code{component}/@var{real-name}}, where
>> +@var{real-name} is the object file's real name, as described above.
>
> In my review, I suggested a better wording for this sentence.  Please
> use it.
>

Ah.  Missed that:

> If this file does not exist, and if the parameter
> @code{debug-file-directory} is set (@pxref{Separate Debug Files}),
> then @value{GDBN} will look for the file in all of the directories
> mentioned in the value of @code{debug-file-directory}.

I think the new wording still isn't sufficiently clear.
It doesn't say that each element in debug-file-directory is
concatenated with the full file name.  The user might think that only
the base name of the file is used.
[At least that is my understanding of how debug-file-directory would be used.]


  reply	other threads:[~2010-04-21 21:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-16  7:06 Doug Evans
2010-04-16  9:38 ` Eli Zaretskii
2010-04-16 18:06   ` Doug Evans
2010-04-16 21:25     ` Eli Zaretskii
2010-04-20 21:45       ` Doug Evans
2010-04-21 19:23         ` Doug Evans
2010-04-21 20:39           ` Eli Zaretskii
2010-04-21 21:54             ` Doug Evans [this message]
2010-04-22  3:13               ` Eli Zaretskii
2010-04-23 18:10                 ` Doug Evans
2010-04-20 19:13 ` Tom Tromey
2010-04-20 21:38   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2xe394668d1004211454qf3b0f7fajcd740a3022662e93@mail.gmail.com \
    --to=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox