From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31303 invoked by alias); 21 Apr 2010 21:54:23 -0000 Received: (qmail 31257 invoked by uid 22791); 21 Apr 2010 21:54:20 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SARE_MSGID_LONG45,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 21:54:11 +0000 Received: from hpaq2.eem.corp.google.com (hpaq2.eem.corp.google.com [10.3.21.2]) by smtp-out.google.com with ESMTP id o3LLs8Pf003897 for ; Wed, 21 Apr 2010 23:54:08 +0200 Received: from pwi2 (pwi2.prod.google.com [10.241.219.2]) by hpaq2.eem.corp.google.com with ESMTP id o3LLs15c025388 for ; Wed, 21 Apr 2010 23:54:06 +0200 Received: by pwi2 with SMTP id 2so5270383pwi.28 for ; Wed, 21 Apr 2010 14:54:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.141.91.13 with HTTP; Wed, 21 Apr 2010 14:54:05 -0700 (PDT) In-Reply-To: <83eii84k4c.fsf@gnu.org> References: <20100416070540.4205E84396@ruffy.mtv.corp.google.com> <83tyrbwxex.fsf@gnu.org> <83bpdjccpc.fsf@gnu.org> <83eii84k4c.fsf@gnu.org> Date: Wed, 21 Apr 2010 21:54:00 -0000 Received: by 10.141.4.9 with SMTP id g9mr1205097rvi.232.1271886846056; Wed, 21 Apr 2010 14:54:06 -0700 (PDT) Message-ID: Subject: Re: [RFA] [1/2] auto-loading scripts from .debug_gdb_scripts section From: Doug Evans To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00710.txt.bz2 On Wed, Apr 21, 2010 at 1:37 PM, Eli Zaretskii wrote: >> Date: Wed, 21 Apr 2010 12:23:16 -0700 >> From: Doug Evans >> >> I've applied the requested doc changes, except that Auto-loading is >> still moved up one level, moved from node Python API to node Python. > > Thanks. > >> +If this file does not exist, and if the parameter >> +@code{debug-file-directory} is set (@pxref{Separate Debug Files}), >> +then @value{GDBN} will use for its each separated directory component >> +@code{component} the file named @file{@code{component}/@var{real-name}}= , where >> +@var{real-name} is the object file's real name, as described above. > > In my review, I suggested a better wording for this sentence. =A0Please > use it. > Ah. Missed that: > If this file does not exist, and if the parameter > @code{debug-file-directory} is set (@pxref{Separate Debug Files}), > then @value{GDBN} will look for the file in all of the directories > mentioned in the value of @code{debug-file-directory}. I think the new wording still isn't sufficiently clear. It doesn't say that each element in debug-file-directory is concatenated with the full file name. The user might think that only the base name of the file is used. [At least that is my understanding of how debug-file-directory would be use= d.]