From: Vladimir Prus <ghost@cs.msu.su>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Typos in gdb/mi
Date: Tue, 19 Aug 2014 06:55:00 -0000 [thread overview]
Message-ID: <lsusda$1hs$1@ger.gmane.org> (raw)
In-Reply-To: <20140818151728.GA4841@adacore.com>
On 08/18/2014 07:17 PM, Joel Brobecker wrote:
>> I understand the motivation for making the change, and it does make
>> the code better; thanks for taking the time!
>>
>> However, I was burned in past, when such cleanup patches caused merge
>> problems for any local patches anybody might have. I wonder what
>> others think?
>
> If it makes the code better, let's push it. It's not the contributor's
> fault that other people's as-yet-unpushed patches may or may not collide.
> If we have conflicting patches, their authors will just have to adjust,
> as we often do when doing collaborative work on the same area of the code.
The question is whether combined price the community will pay for such
adjustment is not greater than any improvements due to fixed typos.
I'd be happy to go with your guidance, as far as GDB goes.
I've looked at the patch, and see nothing wrong. Simon, can you push it for
Andreas?
Thanks,
Volodya
next prev parent reply other threads:[~2014-08-19 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:49 Andreas From
2014-08-18 14:03 ` Vladimir Prus
2014-08-18 15:17 ` Joel Brobecker
2014-08-18 15:48 ` Simon Marchi
2014-08-19 6:43 ` Joel Brobecker
2014-08-19 6:55 ` Vladimir Prus [this message]
2014-08-19 7:12 ` Joel Brobecker
2014-08-19 14:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='lsusda$1hs$1@ger.gmane.org' \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox