From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10107 invoked by alias); 19 Aug 2014 06:55:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10095 invoked by uid 89); 19 Aug 2014 06:55:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 19 Aug 2014 06:55:52 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XJdKf-00030H-CR for gdb-patches@sourceware.org; Tue, 19 Aug 2014 08:55:49 +0200 Received: from h86-62-88-129.ln.rinet.ru ([86.62.88.129]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 19 Aug 2014 08:55:49 +0200 Received: from ghost by h86-62-88-129.ln.rinet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 19 Aug 2014 08:55:49 +0200 To: gdb-patches@sourceware.org From: Vladimir Prus Subject: Re: [PATCH] Typos in gdb/mi Date: Tue, 19 Aug 2014 06:55:00 -0000 Message-ID: References: <53F1BDFA.1090101@ericsson.com> <20140818151728.GA4841@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 In-Reply-To: <20140818151728.GA4841@adacore.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00333.txt.bz2 On 08/18/2014 07:17 PM, Joel Brobecker wrote: >> I understand the motivation for making the change, and it does make >> the code better; thanks for taking the time! >> >> However, I was burned in past, when such cleanup patches caused merge >> problems for any local patches anybody might have. I wonder what >> others think? > > If it makes the code better, let's push it. It's not the contributor's > fault that other people's as-yet-unpushed patches may or may not collide. > If we have conflicting patches, their authors will just have to adjust, > as we often do when doing collaborative work on the same area of the code. The question is whether combined price the community will pay for such adjustment is not greater than any improvements due to fixed typos. I'd be happy to go with your guidance, as far as GDB goes. I've looked at the patch, and see nothing wrong. Simon, can you push it for Andreas? Thanks, Volodya