From: Vladimir Prus <ghost@cs.msu.su>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Typos in gdb/mi
Date: Mon, 18 Aug 2014 14:03:00 -0000 [thread overview]
Message-ID: <lst13c$ogq$1@ger.gmane.org> (raw)
In-Reply-To: <53F1BDFA.1090101@ericsson.com>
On 08/18/2014 12:48 PM, Andreas From wrote:
> Hi,
>
> This is a first patch for setting up the account.
>
> I fixed miscellaneous typos and capitalization for "gdb", "gcc", "mi" and "cli" and replaced "var obj" -> "varobj" in code comments in MI
> parts.
>
> I de-capitalized VAROBJ in one comment since it is not a variable but the type referred to.
>
> Would this be OK to commit? And, if so, can someone help me further with access for pushing?
Hi Andreas,
I understand the motivation for making the change, and it does make the code better; thanks for taking the time!
However, I was burned in past, when such cleanup patches caused merge problems for any local patches
anybody might have. I wonder what others think?
- Volodya
next prev parent reply other threads:[~2014-08-18 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:49 Andreas From
2014-08-18 14:03 ` Vladimir Prus [this message]
2014-08-18 15:17 ` Joel Brobecker
2014-08-18 15:48 ` Simon Marchi
2014-08-19 6:43 ` Joel Brobecker
2014-08-19 6:55 ` Vladimir Prus
2014-08-19 7:12 ` Joel Brobecker
2014-08-19 14:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='lst13c$ogq$1@ger.gmane.org' \
--to=ghost@cs.msu.su \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox